From 5232684467f356b2bd110a67c6ae0e7aaa594704 Mon Sep 17 00:00:00 2001 From: Gabriel Arazas Date: Sun, 21 Jan 2024 20:12:51 +0800 Subject: [PATCH] chore: update notes for gnome-session --- modules/nixos/programs/gnome-session/submodules.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/nixos/programs/gnome-session/submodules.nix b/modules/nixos/programs/gnome-session/submodules.nix index 78bf0343..116f95f0 100644 --- a/modules/nixos/programs/gnome-session/submodules.nix +++ b/modules/nixos/programs/gnome-session/submodules.nix @@ -265,12 +265,19 @@ rec { know how different desktop components interact with each other especially if one of them failed. + * Even if we have a way to limit starting desktop components with + `systemd-xdg-autostart-condition`, using `Service.ExecCondition=` + would severely limit possible reuse of desktop components with other + NixOS-module-generated gnome-session sessions so we're not bothering + with those. + TODO: Is `Type=notify` a good default? * `Service.Type=` is obviously not included since not all desktop components are the same either. Some of them could a D-Bus service, some of them are oneshots, etc. Not to mention, this is already implied to be `Type=simple` by systemd anyways. + TODO: A good balance for this value, probably? * `Service.OOMScoreAdjust=` have different values for different components so it isn't included.