flake-parts/setups: refactor

modules/flake-parts/setups/home-manager.nix

@@ -251,18 +251,17 @@ in
                   )
                   metadata.systems);
           in
-          lib.mapAttrs
+          lib.mapAttrs generatePureConfigs cfg.configs;
-            (hostname: metadata:
-              generatePureConfigs hostname metadata)
-            cfg.configs;
       in
       {
         homeConfigurations =
+          let
+            renameSystems = name: system: config:
+              lib.nameValuePair "${name}-${system}" config;
+          in
           lib.concatMapAttrs
             (name: configs:
-              lib.mapAttrs'
+              lib.mapAttrs' (renameSystems name) configs)
-                (system: config: lib.nameValuePair "${name}-${system}" config)
-                configs)
             pureHomeManagerConfigs;
 
         deploy.nodes =
@@ -271,25 +270,25 @@ in
               lib.filterAttrs
                 (name: _: cfg.configs.${name}.deploy != null)
                 pureHomeManagerConfigs;
+
+            generateDeployNode = name: system: config:
+              lib.nameValuePair "home-manager-${name}-${system}" (
+                let
+                  deployConfig = cfg.configs.${name}.deploy;
+                  deployConfig' = lib.attrsets.removeAttrs deployConfig [ "profiles" ];
+                in
+                  deployConfig'
+                  // {
+                    profiles =
+                      cfg.configs.${name}.deploy.profiles {
+                        inherit name config system;
+                      };
+                  }
+              );
           in
           lib.concatMapAttrs
             (name: configs:
-              lib.mapAttrs'
+              lib.mapAttrs' (generateDeployNode name) configs)
-                (system: config: lib.nameValuePair "home-manager-${name}-${system}"
-                  (
-                    let
-                      deployConfig = cfg.configs.${name}.deploy;
-                      deployConfig' = lib.attrsets.removeAttrs deployConfig [ "profiles" ];
-                    in
-                      deployConfig'
-                      // {
-                        profiles =
-                          cfg.configs.${name}.deploy.profiles {
-                            inherit name config system;
-                          };
-                      }
-                  ))
-                  configs)
             validConfigs;
       };
   };

modules/flake-parts/setups/nixos.nix

@@ -330,18 +330,17 @@ in
                   )
                   metadata.systems);
           in
-          lib.mapAttrs
+          lib.mapAttrs generatePureConfigs validConfigs;
-            (hostname: metadata:
-              generatePureConfigs hostname metadata)
-            validConfigs;
       in
       {
         nixosConfigurations =
+          let
+            renameSystems = name: system: config:
+              lib.nameValuePair "${name}-${system}" config;
+          in
           lib.concatMapAttrs
             (name: configs:
-              lib.mapAttrs'
+              lib.mapAttrs' (renameSystems name) configs)
-                (system: config: lib.nameValuePair "${name}-${system}" config)
-                configs)
             pureNixosConfigs;
 
         deploy.nodes =
@@ -350,25 +349,26 @@ in
               lib.filterAttrs
                 (name: _: cfg.configs.${name}.deploy != null)
                 pureNixosConfigs;
+
+            generateDeployNode = name: system: config:
+              lib.nameValuePair "nixos-${name}-${system}"
+                (
+                  let
+                    deployConfig = cfg.configs.${name}.deploy;
+                    deployConfig' = lib.attrsets.removeAttrs deployConfig [ "profiles" ];
+                  in
+                    deployConfig'
+                    // {
+                      profiles =
+                        cfg.configs.${name}.deploy.profiles {
+                          inherit name config system;
+                        };
+                    }
+                );
           in
           lib.concatMapAttrs
             (name: configs:
-              lib.mapAttrs'
+              lib.mapAttrs' (generateDeployNode name) configs)
-                (system: config: lib.nameValuePair "nixos-${name}-${system}"
-                  (
-                    let
-                      deployConfig = cfg.configs.${name}.deploy;
-                      deployConfig' = lib.attrsets.removeAttrs deployConfig [ "profiles" ];
-                    in
-                      deployConfig'
-                      // {
-                        profiles =
-                          cfg.configs.${name}.deploy.profiles {
-                            inherit name config system;
-                          };
-                      }
-                  ))
-                configs)
             validConfigs;
       };
 
@@ -382,23 +382,21 @@ in
 
           generateImages = name: metadata:
             let
+              buildImage = format:
+                lib.nameValuePair
+                  "${name}-${format}"
+                  (mkImage {
+                    inherit (metadata) nixpkgsBranch;
+                    inherit system format;
+                    extraModules = cfg.sharedModules ++ metadata.modules;
+                  });
+
               images =
-                builtins.map
+                builtins.map buildImage metadata.formats;
-                  (format:
-                    lib.nameValuePair
-                      "${name}-${format}"
-                      (mkImage {
-                        inherit (metadata) nixpkgsBranch;
-                        inherit system format;
-                        extraModules = cfg.sharedModules ++ metadata.modules;
-                      }))
-                  metadata.formats;
             in
               lib.listToAttrs images;
         in
-        lib.concatMapAttrs
+        lib.concatMapAttrs generateImages validImages;
-          (name: metadata: generateImages name metadata)
-          validImages;
     };
   };
 }